fix(data-objectstack): a string `$orderby` reaches the server as a sort, not a list of character indices (#3106) by os-zhuang · Pull Request #3109 · objectstack-ai/objectui

os-zhuang · 2026-07-31T08:54:16Z

What

QueryParams['$orderby'] declares four shapes — string, string[], SortNode[], Record<field, direction>. Both find() routes carried their own copy of the fold that serializes it, and both copies handled the same three of them.

The bare string fell through to the Record branch, where Object.entries('name asc') enumerates the string's character indices:

GET /api/v1/data/account?sort=0,1,2,3,4,5,6,7

(That URL is copied from a test run against the pre-fix code, not constructed by hand.)

Why it matters

Since objectstack#4226 the server refuses a sort it cannot read (400 INVALID_SORT) rather than dropping it silently. So this was never a degraded ordering — it was a list that failed to load outright.

`${field} ${order}` is exactly what ObjectGrid builds from its view metadata's sort (ObjectGrid.tsx:536-547), so every standalone ObjectGrid with a configured sort was broken. The ListView path sends the array form and was unaffected, which is why this survived: the two callers disagreed about the shape and only one of them was ever exercised.

How

One exported serializeOrderBy now backs both routes — the same consolidation the filter path already has, and for the same reason (#3713's "two readers of one contract"): two copies of a fold can only agree by inspection, and these two did not.

Tests

orderby-serialization.test.ts runs every declared shape down both routes and asserts they agree — 27 cases. Verified they fail against the pre-fix code (that is where the sort=0,1,2… above comes from).

Net typecheck effect is negative-error: the two TS7006 implicit-any errors in the deleted folds are gone.

Scope

Found while scoping #3106 (column-header sort under server pagination). Independent of that fix and landing first — it is broken on main today, with or without #3106.

🤖 Generated with Claude Code

…rt, not a list of character indices (#3106) `QueryParams['$orderby']` declares four shapes — `string`, `string[]`, `SortNode[]`, `Record<field, direction>`. Both `find()` routes carried their own copy of the fold that serializes it (`convertQueryParams` for a plain read, `rawFindWithPopulate` for one carrying `$expand`/`$search`), and both copies handled the same three. The bare string fell through to the `Record` branch, where `Object.entries('name asc')` enumerates the string's character indices — so the request went out as `sort=0,1,2,3,4,5,6,7`. Since objectstack#4226 the server refuses a sort it cannot read (`400 INVALID_SORT`) rather than dropping it, so this was not a degraded ordering but a list that failed to load outright. `"${field} ${order}"` is exactly what `ObjectGrid` builds from its view metadata's `sort`, which made every standalone grid with a configured sort a broken one. One exported `serializeOrderBy` now backs both routes, for the same reason the filter path already shares one: two copies of a fold can only agree by inspection, and these two did not. The new suite runs every declared shape down both routes and asserts they agree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vercel · 2026-07-31T08:54:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 31, 2026 8:54am

github-actions · 2026-07-31T08:57:50Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-DHwfanl6.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.26KB	2.99KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	474.19KB	103.88KB
core (index.js)	2.20KB	0.79KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.20KB	34.74KB
fields (index.js)	222.06KB	54.35KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.44KB	10.66KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	60.52KB	17.11KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	111.59KB	28.74KB
plugin-designer (index.js)	210.51KB	42.50KB
plugin-detail (index.js)	221.90KB	54.29KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.38KB	26.93KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	182.21KB	48.24KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	104.87KB	25.18KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	40.32KB	10.53KB
plugin-timeline (index.js)	25.75KB	7.32KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	83.54KB	20.39KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	3.47KB	1.54KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.45KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	1.08KB	0.64KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added data-adapter tests labels Jul 31, 2026

This was referenced Jul 31, 2026

feat(components,grid,list): a column-header sort orders the whole list, not the page you can see (#3106) #3112

Merged

fix(detail): a related list has one sorting semantics instead of two (#3106) #3113

Merged

os-zhuang merged commit a17ef09 into main Jul 31, 2026
16 checks passed

os-zhuang deleted the claude/orderby-string-serialization branch July 31, 2026 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(data-objectstack): a string `$orderby` reaches the server as a sort, not a list of character indices (#3106) - #3109

fix(data-objectstack): a string `$orderby` reaches the server as a sort, not a list of character indices (#3106)#3109
os-zhuang merged 1 commit into
mainfrom
claude/orderby-string-serialization

os-zhuang commented Jul 31, 2026

Uh oh!

vercel Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 31, 2026

What

Why it matters

How

Tests

Scope

Uh oh!

vercel Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant